EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: assign dummy values to missing applicant data fields

Browse Source 
This fix avoids rejection of API requests due to missing data of the
applicant. The current user most probably is not aware about this so
they get confused about the error messages otherwise.
This commit is contained in:
Björn Fromme
2026-01-06 14:29:41 +01:00
parent 8bdc33b4f0
commit db1de2653c
1 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/BusProNet/DataProcessor/PersonalDataSynchronizer.php
+38
View File
@@ -23,6 +23,9 @@ class PersonalDataSynchronizer
* Processes all active participants (status 'F' or 'A'). Skips canceled participants (status 'S').
* Updates all personal data fields and communication information.
*
* For the applicant (index 0), missing mandatory fields are filled with defaults
* to handle company applicants created by travel agencies.
*
* IMPORTANT: The applicant's address must never be modified. This method updates
* participant addresses independently to ensure applicant data remains intact.
*
@@ -37,6 +40,11 @@ class PersonalDataSynchronizer
continue;
}
// Fill missing mandatory fields for applicant (company bookings by travel agencies)
if (0 === $participant->index) {
$this->fillMissingMandatoryFields($participant);
}
$bookingData->participants[$participant->index]->firstName = $participant->firstName;
$bookingData->participants[$participant->index]->name = $participant->lastName;
$bookingData->participants[$participant->index]->dateOfBirth = $participant->dateOfBirth;
@@ -68,4 +76,34 @@ class PersonalDataSynchronizer
}
}
}
/**
* Fills missing mandatory fields with defaults for company applicants.
*
* Travel agencies often create bookings with company data as the applicant,
* which lacks personal data fields. These fields are mandatory for the BPN
* API, so we fill them with sensible defaults.
*/
private function fillMissingMandatoryFields(ParticipantDto $participant): void
{
if (null === $participant->firstName || '' === $participant->firstName) {
$participant->firstName = 'Anmelder';
}
if (null === $participant->gender || '' === $participant->gender) {
$participant->gender = 'D';
}
if (null === $participant->nationality || '' === $participant->nationality) {
$participant->nationality = 'D';
}
if (null === $participant->dateOfBirth) {
$participant->dateOfBirth = new \DateTimeImmutable('-20 years');
}
if (null === $participant->mobile || '' === $participant->mobile) {
$participant->mobile = '12345';
}
}
}