feat: admin list filtering and search

src/Controller/Admin/AccommodationBooking/FilterController.php

@@ -0,0 +1,54 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Controller\Admin\AccommodationBooking;
+
+use App\Controller\Traits\ListFilterTrait;
+use App\Entity\User;
+use App\Form\Admin\Filter\AccommodationBookingFilterOptionsProvider;
+use App\Form\Admin\Filter\AccommodationBookingFilterType;
+use App\Form\Model\Filter\AccommodationBookingFilterDto;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Attribute\Route;
+use Symfony\Component\Security\Http\Attribute\IsGranted;
+
+/**
+ * Renders the filter modal, pre-filled with whatever the list is currently showing.
+ *
+ * There is no submit action to go with it: the form is a GET form pointing at the list itself,
+ * so applying a filter is a plain navigation.
+ */
+#[IsGranted('ROLE_GROUPS_MANAGER')]
+class FilterController extends AbstractController
+{
+    use ListFilterTrait;
+
+    public function __construct(
+        private readonly AccommodationBookingFilterOptionsProvider $filterOptions,
+    ) {
+    }
+
+    #[Route('/admin/accommodation-booking/filter', name: 'app_admin_accommodationbooking_filter', methods: ['GET'])]
+    public function filter(Request $request): Response
+    {
+        // ROLE_ADMIN inherits ROLE_GROUPS_ADMIN, so this single check covers both.
+        $seesAllBookings = $this->isGranted('ROLE_GROUPS_ADMIN');
+        $user = $this->getUser();
+
+        $filterView = $this->createListFilterView(
+            $request,
+            AccommodationBookingFilterType::class,
+            AccommodationBookingFilterDto::defaults($seesAllBookings, $user instanceof User ? $user : null),
+            'app_admin_accommodationbooking',
+            $this->filterOptions->formOptions($seesAllBookings),
+        );
+
+        return $this->render('admin/accommodation_booking/modal_filter.html.twig', [
+            'form' => $filterView,
+            'route' => 'app_admin_accommodationbooking',
+        ]);
+    }
+}

src/Controller/Admin/AccommodationBooking/IndexController.php

@@ -4,6 +4,11 @@ declare(strict_types=1);
 
 namespace App\Controller\Admin\AccommodationBooking;
 
+use App\Controller\Traits\ListFilterTrait;
+use App\Entity\User;
+use App\Form\Admin\Filter\AccommodationBookingFilterOptionsProvider;
+use App\Form\Admin\Filter\AccommodationBookingFilterType;
+use App\Form\Model\Filter\AccommodationBookingFilterDto;
 use App\Repository\Groups\AccommodationBookingRepository;
 use Knp\Component\Pager\PaginatorInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
@@ -15,8 +20,11 @@ use Symfony\Component\Security\Http\Attribute\IsGranted;
 #[IsGranted('ROLE_GROUPS_MANAGER')]
 class IndexController extends AbstractController
 {
+    use ListFilterTrait;
+
     public function __construct(
         private readonly AccommodationBookingRepository $bookingRepository,
+        private readonly AccommodationBookingFilterOptionsProvider $filterOptions,
         private readonly PaginatorInterface $paginator,
     ) {
     }
@@ -24,21 +32,33 @@ class IndexController extends AbstractController
     #[Route('/admin/accommodation-booking', name: 'app_admin_accommodationbooking')]
     public function index(Request $request): Response
     {
-        $today = new \DateTimeImmutable('today');
+        // ROLE_ADMIN inherits ROLE_GROUPS_ADMIN, so this single check covers both.
+        $seesAllBookings = $this->isGranted('ROLE_GROUPS_ADMIN');
+        $user = $this->getUser();
+        $user = $user instanceof User ? $user : null;
 
-        $qb = $this
-            ->bookingRepository
-            ->createQueryBuilder('booking')
-            ->select('booking', 'managed_by')
-            ->leftJoin('booking.accommodation', 'accommodation')
-            ->leftJoin('booking.managedBy', 'managed_by')
-            ->addSelect('accommodation')
-            ->where('booking.dateTo >= :today')
-            ->setParameter('today', $today)
-        ;
+        // The form writes into $filter, so after this call it holds either the defaults or
+        // whatever the query string asked for.
+        $filter = AccommodationBookingFilterDto::defaults($seesAllBookings, $user);
+
+        $filterView = $this->createListFilterView(
+            $request,
+            AccommodationBookingFilterType::class,
+            $filter,
+            'app_admin_accommodationbooking',
+            $this->filterOptions->formOptions($seesAllBookings),
+        );
+
+        // The manager fields are not part of the form for this role, but the scope is pinned
+        // here as well so that a hand-written query parameter cannot widen it either.
+        if (!$seesAllBookings) {
+            $filter->managedBy = $user;
+            $filter->unassigned = false;
+            $filter->managedByLocked = true;
+        }
 
         $pagination = $this->paginator->paginate(
-            $qb,
+            $this->bookingRepository->createFilteredQueryBuilder($filter),
             $request->query->getInt('page', 1),
             $request->query->getInt('limit', 20),
             [
@@ -49,6 +69,8 @@ class IndexController extends AbstractController
 
         return $this->render('admin/accommodation_booking/index.html.twig', [
             'pagination' => $pagination,
+            'filter' => $filter,
+            'filter_form' => $filterView,
         ]);
     }
 }