feat: backup previous password, change password via personal data form

tests/Controller/Account/PersonalDataControllerTest.php

@@ -21,6 +21,7 @@ use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Component\Security\Core\User\UserInterface;
+use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintValidatorFactory;
 use Symfony\Component\Validator\ConstraintValidatorInterface;
@@ -189,6 +190,7 @@ class PersonalDataControllerTest extends TestCase
         $controller->entityManager
             ->expects(self::once())
             ->method('flush');
+        $controller->passwordHasher->expects(self::never())->method('hashPassword');
 
         $request = Request::create('/personal-data', 'POST');
         $request->setSession(new Session(new MockArraySessionStorage()));
@@ -196,18 +198,108 @@ class PersonalDataControllerTest extends TestCase
 
         self::assertSame(302, $response->getStatusCode());
         self::assertTrue($controller->user->isProfileComplete());
+        self::assertSame('secret', $controller->user->getPassword());
+        self::assertSame('legacy-backup', $controller->user->getPreviousPassword());
         self::assertSame([
             ['success', 'Deine persönlichen Daten wurden aktualisiert'],
         ], $controller->flashes);
     }
 
+    public function testIndexHashesPasswordWhenNewPasswordWasProvided(): void
+    {
+        $personalData = $this->createCompletePersonalData();
+        $controller = $this->createController(true, true, $this->validator(), 'NewPassw0rd!');
+
+        $controller->apiClient
+            ->expects(self::once())
+            ->method('getPersonalData')
+            ->with('[email protected]', null, null)
+            ->willReturn($personalData);
+        $controller->apiClient
+            ->expects(self::once())
+            ->method('updatePersonalData')
+            ->with('[email protected]', $personalData)
+            ->willReturn($personalData);
+        $controller->newsletterManager
+            ->expects(self::once())
+            ->method('hasConfirmedOptIn')
+            ->with('[email protected]')
+            ->willReturn(false);
+        $controller->newsletterManager
+            ->expects(self::once())
+            ->method('hasPendingConfirmation')
+            ->with('[email protected]')
+            ->willReturn(false);
+        $controller->dataLoader
+            ->expects(self::once())
+            ->method('invalidateUserBookingCaches')
+            ->with($controller->user);
+        $controller->entityManager
+            ->expects(self::once())
+            ->method('flush');
+        $controller->passwordHasher
+            ->expects(self::once())
+            ->method('hashPassword')
+            ->with($controller->user, 'NewPassw0rd!')
+            ->willReturn('new-local-hash');
+
+        $request = Request::create('/personal-data', 'POST');
+        $request->setSession(new Session(new MockArraySessionStorage()));
+        $response = $controller->index($request);
+
+        self::assertSame(302, $response->getStatusCode());
+        self::assertTrue($controller->user->isProfileComplete());
+        self::assertSame('new-local-hash', $controller->user->getPassword());
+        self::assertSame('legacy-backup', $controller->user->getPreviousPassword());
+        self::assertSame([
+            ['success', 'Deine persönlichen Daten wurden aktualisiert'],
+        ], $controller->flashes);
+    }
+
+    public function testIndexDoesNotPersistInvalidFormSubmission(): void
+    {
+        $controller = $this->createController(true, false, $this->validator(), 'NewPassw0rd!');
+
+        $controller->apiClient
+            ->expects(self::once())
+            ->method('getPersonalData')
+            ->with('[email protected]', null, null)
+            ->willReturn($this->createCompletePersonalData());
+        $controller->apiClient->expects(self::never())->method('updatePersonalData');
+        $controller->newsletterManager
+            ->expects(self::once())
+            ->method('hasConfirmedOptIn')
+            ->with('[email protected]')
+            ->willReturn(false);
+        $controller->newsletterManager
+            ->expects(self::once())
+            ->method('hasPendingConfirmation')
+            ->with('[email protected]')
+            ->willReturn(false);
+        $controller->dataLoader->expects(self::never())->method('invalidateUserBookingCaches');
+        $controller->entityManager->expects(self::never())->method('flush');
+        $controller->passwordHasher->expects(self::never())->method('hashPassword');
+
+        $request = Request::create('/personal-data', 'POST');
+        $request->setSession(new Session(new MockArraySessionStorage()));
+        $response = $controller->index($request);
+
+        self::assertSame(200, $response->getStatusCode());
+        self::assertSame('account/personal_data.html.twig', $controller->renderedView);
+        self::assertSame([], $controller->flashes);
+        self::assertSame('secret', $controller->user->getPassword());
+        self::assertSame('legacy-backup', $controller->user->getPreviousPassword());
+    }
+
     private function createController(
         bool $submitted = false,
         bool $valid = false,
         ?ValidatorInterface $validator = null,
+        string $newPassword = '',
     ): TestablePersonalDataController {
         $user = new User('[email protected]');
         $user->setPassword('secret');
+        $user->setPreviousPassword('legacy-backup');
 
         $apiClient = $this->createMock(ApiClient::class);
 
@@ -221,6 +313,14 @@ class PersonalDataControllerTest extends TestCase
         $form
             ->method('isValid')
             ->willReturn($valid);
+        $newPasswordField = $this->createMock(FormInterface::class);
+        $newPasswordField
+            ->method('getData')
+            ->willReturn($newPassword);
+        $form
+            ->method('get')
+            ->with('newPassword')
+            ->willReturn($newPasswordField);
 
         $validator ??= $this->createMock(ValidatorInterface::class);
 
@@ -230,6 +330,7 @@ class PersonalDataControllerTest extends TestCase
             $validator,
             $this->createMock(EntityManagerInterface::class),
             $this->createMock(NewsletterManager::class),
+            $this->createMock(UserPasswordHasherInterface::class),
             $this->createMock(LoggerInterface::class),
             $user,
             $form,
@@ -301,6 +402,7 @@ final class TestablePersonalDataController extends PersonalDataController
         public readonly ValidatorInterface $validator,
         public readonly EntityManagerInterface $entityManager,
         public readonly NewsletterManager $newsletterManager,
+        public readonly UserPasswordHasherInterface $passwordHasher,
         LoggerInterface $logger,
         public readonly User $user,
         private readonly FormInterface $form,
@@ -311,6 +413,7 @@ final class TestablePersonalDataController extends PersonalDataController
             $validator,
             $entityManager,
             $newsletterManager,
+            $passwordHasher,
             $logger,
         );
     }