feat: re-generate access links for bookings when sent via email

src/Controller/Admin/AccommodationBooking/GenerateAccessLinkController.php

@@ -1,55 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace App\Controller\Admin\AccommodationBooking;
-
-use App\Entity\Groups\AccommodationBooking;
-use App\Htmx\HxRedirectResponse;
-use App\Service\AccommodationBookingService;
-use Psr\Log\LoggerInterface;
-use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
-use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Attribute\Route;
-use Symfony\Component\Security\Http\Attribute\IsGranted;
-
-#[IsGranted('ROLE_GROUPS_MANAGER')]
-class GenerateAccessLinkController extends AbstractController
-{
-    public function __construct(
-        private readonly AccommodationBookingService $bookingService,
-        private readonly LoggerInterface $logger,
-    ) {
-    }
-
-    #[Route('/admin/accommodation-booking/{id}/generate-access-link', name: 'app_admin_accommodationbooking_generate_access_link')]
-    public function index(AccommodationBooking $booking, Request $request): Response
-    {
-        // A draft has not been offered to anyone yet, so there is nothing a link could show.
-        if (!$booking->isCustomerAccessible()) {
-            return $this->redirectToRoute('app_admin_accommodationbooking_show', ['id' => $booking->getId()]);
-        }
-
-        if ($request->isMethod(Request::METHOD_POST)) {
-            if (!$this->isCsrfTokenValid('generate_accommodation_booking_access_link_'.$booking->getId(), $request->request->getString('_token'))) {
-                throw $this->createAccessDeniedException('Invalid CSRF token.');
-            }
-
-            $this->bookingService->regenerateAccessLink($booking);
-
-            $this->addFlash('success', 'Der Zugangslink wurde neu generiert.');
-
-            $this->logger->info('Generated accommodation booking access link', [
-                'id' => $booking->getId(),
-            ]);
-
-            return new HxRedirectResponse($this->generateUrl('app_admin_accommodationbooking_show', ['id' => $booking->getId()]));
-        }
-
-        return $this->render('admin/accommodation_booking/modal_generate_access_link.html.twig', [
-            'booking' => $booking,
-            'csrf_token_id' => 'generate_accommodation_booking_access_link_'.$booking->getId(),
-        ]);
-    }
-}

src/Controller/Admin/AccommodationBooking/SendAccessLinkController.php

@@ -43,9 +43,9 @@ class SendAccessLinkController extends AbstractController
                 return new HxRedirectResponse($this->generateUrl('app_admin_accommodationbooking_edit', ['id' => $booking->getId()]));
             }
 
-            $this->bookingService->sendCustomerConfirmationEmail($booking);
+            $this->bookingService->sendAccessLink($booking);
 
-            $this->addFlash('success', 'Der Zugangslink wurde dem Kunden per E-Mail zugestellt.');
+            $this->addFlash('success', 'Ein neuer Zugangslink wurde dem Kunden per E-Mail zugestellt.');
 
             $this->logger->info('Sent accommodation booking access link', [
                 'id' => $booking->getId(),

src/Service/AccommodationBookingService.php

@@ -492,13 +492,15 @@ class AccommodationBookingService
     }
 
     /**
-     * Explicit admin action: (re)issues the access link, invalidating any previously issued
-     * link for this booking. No email side effect — sending is a separate, explicit admin
-     * action via sendCustomerConfirmationEmail().
+     * Explicit admin action: mails the access link again, refreshing its validity first so the
+     * customer always receives a link that is good for another full TTL — the mail is the only
+     * way a link reaches the customer, so sending and issuing belong together.
+     * The previously issued link stops working, which is the point: one booking has one valid
+     * link at a time.
      * A no-op for a record that is not customer accessible yet, for the same reason as
      * issueAccessLink().
      */
-    public function regenerateAccessLink(AccommodationBooking $booking): void
+    public function sendAccessLink(AccommodationBooking $booking): void
     {
         if (!$booking->isCustomerAccessible()) {
             return;
@@ -506,6 +508,8 @@ class AccommodationBookingService
 
         $booking->setAccessLinkIssuedAt(new \DateTimeImmutable());
         $this->entityManager->flush();
+
+        $this->sendCustomerConfirmationEmail($booking);
     }
 
     /**