feat: extract room grouping from booking service

tests/Service/BookingRoomSelectionServiceTest.php

@@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Service;
+
+use App\BusProNet\Model\Room;
+use App\Service\BookingRoomSelectionService;
+use PHPUnit\Framework\TestCase;
+
+class BookingRoomSelectionServiceTest extends TestCase
+{
+    private BookingRoomSelectionService $service;
+
+    protected function setUp(): void
+    {
+        $this->service = new BookingRoomSelectionService();
+    }
+
+    public function testGroupRoomsBySelectionTypeSplitsAndSortsRooms(): void
+    {
+        $rooms = [
+            10 => $this->createRoom(10, '2 Bett Zimmer', 4),
+            11 => $this->createRoom(11, 'Suite', 2),
+            12 => $this->createRoom(12, '3 Bett Zimmer', 6),
+        ];
+
+        $groups = $this->service->groupRoomsBySelectionType($rooms);
+
+        $this->assertSame([10, 12], array_keys($groups[Room::SELECTION_TYPE_BY_PAX]));
+        $this->assertSame([11], array_keys($groups[Room::SELECTION_TYPE_BY_ROOM]));
+    }
+
+    private function createRoom(int $id, string $label, int $maxPax): Room
+    {
+        $room = new Room();
+        $room->id = $id;
+        $room->label = $label;
+        $room->maxPax = $maxPax;
+
+        return $room;
+    }
+}

tests/Service/BookingServiceBabyTest.php

@@ -11,7 +11,6 @@ use App\BusProNet\Service\BookingStatusRuleRegistry;
 use App\BusProNet\XmlLoader\AgencyLoader;
 use App\Form\Model\BookingDto;
 use App\Form\Model\ParticipantDto;
-use App\Service\BookingPriceCalculatorService;
 use App\Service\BookingService;
 use App\Service\BookingSessionService;
 use App\Service\ParticipantEligibilityService;
@@ -26,7 +25,6 @@ class BookingServiceBabyTest extends TestCase
     protected function setUp(): void
     {
         $travelDataService = $this->createMock(TravelDataService::class);
-        $priceCalculator = $this->createMock(BookingPriceCalculatorService::class);
         $this->participantEligibilityService = $this->createMock(ParticipantEligibilityService::class);
         $bookingStatusRuleRegistry = $this->createMock(BookingStatusRuleRegistry::class);
         $bookingStatusRuleRegistry->method('evaluateStatus')->willReturn('F');
@@ -35,7 +33,6 @@ class BookingServiceBabyTest extends TestCase
         $this->bookingService = new BookingService(
             $this->createMock(BookingSessionService::class),
             $travelDataService,
-            $priceCalculator,
             $this->participantEligibilityService,
             $bookingStatusRuleRegistry,
             $agencyLoader,

tests/Service/BookingServiceStatusTest.php

@@ -11,7 +11,6 @@ use App\BusProNet\Model\Travel;
 use App\BusProNet\Service\BookingStatusRuleRegistry;
 use App\BusProNet\XmlLoader\AgencyLoader;
 use App\Exception\NoRoomsAvailableException;
-use App\Service\BookingPriceCalculatorService;
 use App\Service\BookingService;
 use App\Service\BookingSessionService;
 use App\Service\ParticipantEligibilityService;
@@ -30,7 +29,6 @@ class BookingServiceStatusTest extends TestCase
     {
         $bookingSessionService = $this->createMock(BookingSessionService::class);
         $this->travelDataService = $this->createMock(TravelDataService::class);
-        $priceCalculator = $this->createMock(BookingPriceCalculatorService::class);
         $participantEligibility = $this->createMock(ParticipantEligibilityService::class);
         $bookingStatusRuleRegistry = $this->createMock(BookingStatusRuleRegistry::class);
         $bookingStatusRuleRegistry->method('evaluateStatus')->willReturn('F');
@@ -39,7 +37,6 @@ class BookingServiceStatusTest extends TestCase
         $this->bookingService = new BookingService(
             $bookingSessionService,
             $this->travelDataService,
-            $priceCalculator,
             $participantEligibility,
             $bookingStatusRuleRegistry,
             $agencyLoader,
@@ -183,7 +180,6 @@ class BookingServiceStatusTest extends TestCase
         $bookingService = new BookingService(
             $this->createMock(BookingSessionService::class),
             $this->travelDataService,
-            $this->createMock(BookingPriceCalculatorService::class),
             $this->createMock(ParticipantEligibilityService::class),
             $bookingStatusRuleRegistry,
             $this->createMock(AgencyLoader::class),
@@ -215,7 +211,6 @@ class BookingServiceStatusTest extends TestCase
         $bookingService = new BookingService(
             $this->createMock(BookingSessionService::class),
             $this->travelDataService,
-            $this->createMock(BookingPriceCalculatorService::class),
             $this->createMock(ParticipantEligibilityService::class),
             $bookingStatusRuleRegistry,
             $this->createMock(AgencyLoader::class),