EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: reset room assignments after updated selection if required

Browse Source
This commit is contained in:
Björn Fromme
2025-12-11 11:27:48 +01:00
parent b4c03160ca
commit f54f66cd32
3 changed files with 150 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Service/RoomAssignmentServiceTest.php
+103
View File
@@ -190,6 +190,109 @@ class RoomAssignmentServiceTest extends TestCase
self::assertSame(100, $bookingDto->participants[1]->assignedRoomId);
}
/**
* @test
*/
public function validateAndResetInvalidAssignmentsResetsOrphanedAssignments(): void
{
// Create DTO with only room 100 selected
$bookingDto = $this->createBookingDtoWithRoomSelections([
['roomId' => 100, 'quantity' => 2, 'capacity' => 2],
]);
// Create participants with assignments to room 100 and room 200 (no longer selected)
$bookingDto->participants = [
new ParticipantDto(),
new ParticipantDto(),
new ParticipantDto(),
new ParticipantDto(),
];
$bookingDto->participants[0]->assignedRoomId = 100;
$bookingDto->participants[1]->assignedRoomId = 100;
$bookingDto->participants[2]->assignedRoomId = 200; // Invalid - room not selected
$bookingDto->participants[3]->assignedRoomId = 200; // Invalid - room not selected
$result = $this->service->validateAndResetInvalidAssignments($bookingDto);
self::assertTrue($result, 'Should return true when assignments were reset');
self::assertSame(100, $bookingDto->participants[0]->assignedRoomId);
self::assertSame(100, $bookingDto->participants[1]->assignedRoomId);
self::assertNull($bookingDto->participants[2]->assignedRoomId, 'Invalid assignment should be reset to null');
self::assertNull($bookingDto->participants[3]->assignedRoomId, 'Invalid assignment should be reset to null');
}
/**
* @test
*/
public function validateAndResetInvalidAssignmentsReturnsFalseWhenAllValid(): void
{
$bookingDto = $this->createBookingDtoWithRoomSelections([
['roomId' => 100, 'quantity' => 2, 'capacity' => 2],
]);
// All participants assigned to the valid room
$bookingDto->participants = [
new ParticipantDto(),
new ParticipantDto(),
];
$bookingDto->participants[0]->assignedRoomId = 100;
$bookingDto->participants[1]->assignedRoomId = 100;
$result = $this->service->validateAndResetInvalidAssignments($bookingDto);
self::assertFalse($result, 'Should return false when no assignments needed reset');
self::assertSame(100, $bookingDto->participants[0]->assignedRoomId);
self::assertSame(100, $bookingDto->participants[1]->assignedRoomId);
}
/**
* @test
*/
public function validateAndResetInvalidAssignmentsHandlesNullAssignments(): void
{
$bookingDto = $this->createBookingDtoWithRoomSelections([
['roomId' => 100, 'quantity' => 1, 'capacity' => 2],
]);
// Participants with null assignments should not trigger a reset
$bookingDto->participants = [
new ParticipantDto(),
new ParticipantDto(),
];
$bookingDto->participants[0]->assignedRoomId = null;
$bookingDto->participants[1]->assignedRoomId = null;
$result = $this->service->validateAndResetInvalidAssignments($bookingDto);
self::assertFalse($result, 'Should return false when only null assignments exist');
}
/**
* @test
*/
public function validateAndResetInvalidAssignmentsHandlesEmptySelectedRooms(): void
{
// All rooms have quantity 0 (none selected)
$bookingDto = $this->createBookingDtoWithRoomSelections([
['roomId' => 100, 'quantity' => 0, 'capacity' => 2],
['roomId' => 200, 'quantity' => 0, 'capacity' => 2],
]);
// Participants still have old assignments
$bookingDto->participants = [
new ParticipantDto(),
new ParticipantDto(),
];
$bookingDto->participants[0]->assignedRoomId = 100;
$bookingDto->participants[1]->assignedRoomId = 200;
$result = $this->service->validateAndResetInvalidAssignments($bookingDto);
self::assertTrue($result, 'Should return true when all assignments become invalid');
self::assertNull($bookingDto->participants[0]->assignedRoomId);
self::assertNull($bookingDto->participants[1]->assignedRoomId);
}
private function createBookingDtoWithRoomSelections(array $selections): BookingDto
{
$travel = new Travel();