fix: don't require email address from participants under 16

2026-09-01 15:15:58 +02:00
parent 98e0cfcf6f
commit f595183c05
11 changed files with 566 additions and 36 deletions
@@ -73,4 +73,95 @@ class CreateFieldStateProviderTest extends TestCase
            'Dependent insurance field must reappear once the applicant switches away from family insurance'
        );
    }
+
+    public function testEmailIsNotRequiredForNonApplicantChild(): void
+    {
+        $bookingDto = $this->createBookingDtoWithApplicantAndDependent(new \DateTimeImmutable('2015-01-01'));
+
+        $this->assertFalse(
+            $this->provider->getFieldState('email', $bookingDto, 1)['required'],
+            'A child travelling with an applicant does not need an email address of their own'
+        );
+    }
+
+    public function testEmailIsRequiredForNonApplicantAdult(): void
+    {
+        $bookingDto = $this->createBookingDtoWithApplicantAndDependent(new \DateTimeImmutable('1990-01-01'));
+
+        $this->assertTrue($this->provider->getFieldState('email', $bookingDto, 1)['required']);
+    }
+
+    public function testEmailIsRequiredForTheApplicantEvenAsAChild(): void
+    {
+        $bookingDto = $this->createBookingDtoWithApplicantAndDependent(new \DateTimeImmutable('2015-01-01'));
+        $bookingDto->participants[0]->dateOfBirth = new \DateTimeImmutable('2015-01-01');
+
+        $this->assertTrue(
+            $this->provider->getFieldState('email', $bookingDto, 0)['required'],
+            'The applicant is the booking contact and always has to be reachable'
+        );
+    }
+
+    public function testEmailIsRequiredWhenDateOfBirthIsUnknown(): void
+    {
+        $bookingDto = $this->createBookingDtoWithApplicantAndDependent(new \DateTimeImmutable('2015-01-01'));
+        $bookingDto->participants[1]->dateOfBirth = null;
+
+        $this->assertTrue(
+            $this->provider->getFieldState('email', $bookingDto, 1)['required'],
+            'An unknown age counts as an adult'
+        );
+    }
+
+    public function testEmailRequirementFlipsWhenDateOfBirthChanges(): void
+    {
+        $bookingDto = $this->createBookingDtoWithApplicantAndDependent(new \DateTimeImmutable('2015-01-01'));
+        $dependent = $bookingDto->participants[1];
+
+        $this->assertFalse($this->provider->getFieldState('email', $bookingDto, 1)['required']);
+
+        $dependent->dateOfBirth = new \DateTimeImmutable('1990-01-01');
+
+        $this->assertTrue(
+            $this->provider->getFieldState('email', $bookingDto, 1)['required'],
+            'Correcting a child date of birth to an adult one must reinstate the requirement'
+        );
+    }
+
+    /**
+     * Guards the switch from add-only to toggling 'required' state: the two fields that already
+     * used a 'required' condition must keep behaving exactly as before, now reporting false
+     * instead of omitting the key. Both declare 'required' => false as their base in the form
+     * type, so assigning the condition result either way is equivalent to the old add-only pass.
+     */
+    public function testMobileAndAddressRemainRequiredOnlyForTheFirstParticipant(): void
+    {
+        $bookingDto = $this->createBookingDtoWithApplicantAndDependent(new \DateTimeImmutable('1990-01-01'));
+
+        $this->assertTrue($this->provider->getFieldState('mobile', $bookingDto, 0)['required']);
+        $this->assertFalse($this->provider->getFieldState('mobile', $bookingDto, 1)['required']);
+
+        $this->assertTrue($this->provider->getFieldState('address', $bookingDto, 0)['required']);
+        $this->assertFalse($this->provider->getFieldState('address', $bookingDto, 1)['required']);
+    }
+
+    private function createBookingDtoWithApplicantAndDependent(\DateTimeImmutable $dependentDateOfBirth): BookingDto
+    {
+        $travel = new Travel();
+        $travel->dateFrom = new \DateTimeImmutable('+30 days');
+        $travel->dateTo = new \DateTimeImmutable('+37 days');
+
+        $applicant = new ParticipantDto();
+        $applicant->index = 0;
+        $applicant->dateOfBirth = new \DateTimeImmutable('1980-01-01');
+
+        $dependent = new ParticipantDto();
+        $dependent->index = 1;
+        $dependent->dateOfBirth = $dependentDateOfBirth;
+
+        $bookingDto = new BookingDto($travel, 1);
+        $bookingDto->participants = [$applicant, $dependent];
+
+        return $bookingDto;
+    }
 }
@@ -0,0 +1,81 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Tests\Form\Service;
+
+use App\BusProNet\Model\Travel;
+use App\BusProNet\XmlLoader\AgencyLoader;
+use App\Form\Model\BookingDto;
+use App\Form\Model\ParticipantDto;
+use App\Form\Service\EditFieldStateProvider;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Covers the edit-flow email requirement, which follows the same age rule as the create flow
+ * but stands down entirely for internal agency bookings, where staff leave personal data blank.
+ */
+class EditFieldStateProviderTest extends TestCase
+{
+    private EditFieldStateProvider $provider;
+
+    protected function setUp(): void
+    {
+        $this->provider = new EditFieldStateProvider();
+    }
+
+    public function testEmailIsRequiredForNonApplicantAdult(): void
+    {
+        $bookingDto = $this->createBookingDto(new \DateTimeImmutable('1990-01-01'), false);
+
+        $this->assertTrue($this->provider->getFieldState('email', $bookingDto, 1)['required']);
+    }
+
+    public function testEmailIsNotRequiredForNonApplicantChild(): void
+    {
+        $bookingDto = $this->createBookingDto(new \DateTimeImmutable('2015-01-01'), false);
+
+        $this->assertFalse($this->provider->getFieldState('email', $bookingDto, 1)['required']);
+    }
+
+    public function testEmailIsNotRequiredForInternalAgencyBookingsEvenForAdults(): void
+    {
+        $bookingDto = $this->createBookingDto(new \DateTimeImmutable('1990-01-01'), true);
+
+        $this->assertFalse(
+            $this->provider->getFieldState('email', $bookingDto, 1)['required'],
+            'Internal agency bookings leave personal data optional throughout'
+        );
+    }
+
+    public function testEmailIsRequiredForTheApplicantOutsideInternalAgencyBookings(): void
+    {
+        $bookingDto = $this->createBookingDto(new \DateTimeImmutable('1990-01-01'), false);
+
+        $this->assertTrue($this->provider->getFieldState('email', $bookingDto, 0)['required']);
+    }
+
+    private function createBookingDto(\DateTimeImmutable $dependentDateOfBirth, bool $internalAgency): BookingDto
+    {
+        $travel = new Travel();
+        $travel->dateFrom = new \DateTimeImmutable('+30 days');
+        $travel->dateTo = new \DateTimeImmutable('+37 days');
+
+        $applicant = new ParticipantDto();
+        $applicant->index = 0;
+        $applicant->dateOfBirth = new \DateTimeImmutable('1980-01-01');
+
+        $dependent = new ParticipantDto();
+        $dependent->index = 1;
+        $dependent->dateOfBirth = $dependentDateOfBirth;
+
+        $bookingDto = new BookingDto($travel, 1);
+        $bookingDto->participants = [$applicant, $dependent];
+
+        if (true === $internalAgency) {
+            $bookingDto->agencyCode = AgencyLoader::INTERNAL_AGENCY_CODE;
+        }
+
+        return $bookingDto;
+    }
+}