feat: make boarding point price levelling switchable

tests/BusProNet/XmlParser/ApiResponseParserFailureTest.php

@@ -7,6 +7,7 @@ namespace App\Tests\BusProNet\XmlParser;
 use App\BusProNet\ApiClient;
 use App\BusProNet\Exception\ResponseParserException;
 use App\BusProNet\XmlParser\ApiResponseParser;
+use App\BusProNet\XmlParser\TravelParser;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -22,7 +23,7 @@ class ApiResponseParserFailureTest extends TestCase
         $this->expectException(ResponseParserException::class);
         $this->expectExceptionMessage('empty response (0 bytes)');
 
-        (new ApiResponseParser())->parseXmlString(ApiClient::TYPE_NOTIFICATION, '');
+        $this->createParser()->parseXmlString(ApiClient::TYPE_NOTIFICATION, '');
     }
 
     public function testTruncatedResponseNamesTheLibxmlReason(): void
@@ -30,7 +31,7 @@ class ApiResponseParserFailureTest extends TestCase
         $xml = '<?xml version="1.0" encoding="utf-8"?><ergebnis><satz typ="HINWEIS"></satz><hinweis';
 
         try {
-            (new ApiResponseParser())->parseXmlString(ApiClient::TYPE_NOTIFICATION, $xml);
+            $this->createParser()->parseXmlString(ApiClient::TYPE_NOTIFICATION, $xml);
             $this->fail('Expected a ResponseParserException');
         } catch (ResponseParserException $e) {
             self::assertStringContainsString('('.strlen($xml).' bytes)', $e->getMessage());
@@ -45,7 +46,7 @@ class ApiResponseParserFailureTest extends TestCase
         $this->expectException(ResponseParserException::class);
         $this->expectExceptionMessage('Unrecognised BusProNet response type "IRGENDWAS"');
 
-        (new ApiResponseParser())->parseXmlString(ApiClient::TYPE_NOTIFICATION, $xml);
+        $this->createParser()->parseXmlString(ApiClient::TYPE_NOTIFICATION, $xml);
     }
 
     public function testUnknownCustomerDataSubtype(): void
@@ -55,7 +56,7 @@ class ApiResponseParserFailureTest extends TestCase
         $this->expectException(ResponseParserException::class);
         $this->expectExceptionMessage('Unrecognised customer data subtype "Irgendwas"');
 
-        (new ApiResponseParser())->parseXmlString(ApiClient::TYPE_CUSTOMER_DATA, $xml);
+        $this->createParser()->parseXmlString(ApiClient::TYPE_CUSTOMER_DATA, $xml);
     }
 
     public function testDiagnosingDoesNotLeakLibxmlErrorState(): void
@@ -64,7 +65,7 @@ class ApiResponseParserFailureTest extends TestCase
 
         try {
             try {
-                (new ApiResponseParser())->parseXmlString(ApiClient::TYPE_NOTIFICATION, '<ergebnis');
+                $this->createParser()->parseXmlString(ApiClient::TYPE_NOTIFICATION, '<ergebnis');
             } catch (ResponseParserException) {
             }
 
@@ -74,4 +75,12 @@ class ApiResponseParserFailureTest extends TestCase
             libxml_use_internal_errors($previous);
         }
     }
+
+    /**
+     * None of these responses reach the travel parser; a stub keeps the dependency out of view.
+     */
+    private function createParser(): ApiResponseParser
+    {
+        return new ApiResponseParser($this->createStub(TravelParser::class));
+    }
 }

tests/BusProNet/XmlParser/TravelParserTest.php

@@ -6,6 +6,7 @@ namespace App\Tests\BusProNet\XmlParser;
 
 use App\BusProNet\Model\Travel;
 use App\BusProNet\XmlCrawlerFactory;
+use App\BusProNet\XmlParser\AgeConstraintParserRegistry;
 use App\BusProNet\XmlParser\TravelParser;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
@@ -16,7 +17,7 @@ class TravelParserTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->parser = new TravelParser();
+        $this->parser = $this->createParser();
     }
 
     public function testParseServiceDescriptions(): void
@@ -411,7 +412,27 @@ class TravelParserTest extends TestCase
         $this->assertSame(5.9, $travel->dropOffs[99]->price);
     }
 
-    private function parseTravelWithBoardingPoints(string $pickups, string $dropOffs): Travel
+    public function testBoardingPricesAreReportedVerbatimWhenLevellingIsDisabled(): void
+    {
+        // The levelling compensates a vendor export defect and is therefore switchable.
+        // With it off the product 701 shape undercharges the return leg again.
+        $travel = $this->parseTravelWithBoardingPoints(
+            '<zustieg idbuspro="18" zeit="12.12.2026 21:45:00" preis="17,90" />',
+            '<zustieg_rueck idbuspro="18" />',
+            $this->createParser(levelBoardingPointPrices: false)
+        );
+
+        $this->assertSame(17.9, $travel->pickups[18]->price);
+        $this->assertNull($travel->pickups[18]->priceInbound);
+        $this->assertNull($travel->dropOffs[18]->price);
+    }
+
+    private function createParser(bool $levelBoardingPointPrices = true): TravelParser
+    {
+        return new TravelParser(new AgeConstraintParserRegistry(), $levelBoardingPointPrices);
+    }
+
+    private function parseTravelWithBoardingPoints(string $pickups, string $dropOffs, ?TravelParser $parser = null): Travel
     {
         $xmlContent = '<?xml version="1.0" encoding="utf-8"?>
 <reisen>
@@ -426,7 +447,7 @@ class TravelParserTest extends TestCase
 
         $crawler = XmlCrawlerFactory::create($xmlContent);
 
-        return $this->parser->parse($crawler->filterXPath('//reise/termin')->first());
+        return ($parser ?? $this->parser)->parse($crawler->filterXPath('//reise/termin')->first());
     }
 
     public function testGetPickupsAdjustsOvernightTimes(): void