EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: simplify trait to address incorrect arguments

Browse Source
This commit is contained in:
Björn Fromme
2026-03-28 10:18:34 +01:00
parent bca3610cff
commit fbfffbb31a
3 changed files with 23 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Controller/Booking/Create/Step3Controller.php
+13 -15
View File
@@ -76,13 +76,13 @@ class Step3Controller extends AbstractController
$inquiryResponse = $this->apiClient->createBookingInquiry($bookingCreateDto);
if ($inquiryResponse instanceof Notification) {
return $this->handleApiError(
$this->handleApiError(
'Booking inquiry failed',
['message' => $inquiryResponse->message],
$inquiryResponse->message ?? 'Ein Fehler ist aufgetreten. Bitte versuche es erneut oder wende dich an den Kundenservice.',
$bookingCreateDto,
$form
);
return $this->renderStepForm($bookingCreateDto, $form);
}
if (false === $inquiryResponse->isInquiryValid()) {
@@ -109,13 +109,13 @@ class Step3Controller extends AbstractController
$errorMessage .= ' '.$inquiryResponse->message;
}
return $this->handleApiError(
$this->handleApiError(
'Booking inquiry validation failed',
['status' => $inquiryResponse->status, 'message' => $inquiryResponse->message],
$errorMessage,
$bookingCreateDto,
$form
);
return $this->renderStepForm($bookingCreateDto, $form);
}
// Validate price match (rounded to cent precision to avoid floating-point errors)
@@ -133,7 +133,7 @@ class Step3Controller extends AbstractController
$diagnostics = $this->priceMismatchDiagnostics->buildDiagnostics($bookingCreateDto, $inquiryResponse);
$deltaBreakdown = $diagnostics['deltaBreakdown'] ?? [];
return $this->handleApiError(
$this->handleApiError(
'Price mismatch detected - payload incomplete',
[
'apiTotal' => $apiTotal,
@@ -149,9 +149,9 @@ class Step3Controller extends AbstractController
'diagnostics' => $diagnostics,
],
'Preisabweichung festgestellt. Bitte wende dich an den Kundenservice.',
$bookingCreateDto,
$form
);
return $this->renderStepForm($bookingCreateDto, $form);
}
// Validation successful - proceed to confirmation step
@@ -164,28 +164,26 @@ class Step3Controller extends AbstractController
return $this->redirectToRoute('app_booking_create_step_4');
} catch (TimeoutException $e) {
return $this->handleApiError(
$this->handleApiError(
'Booking inquiry timeout',
[
'exception' => $e->getMessage(),
'trace' => $e->getTraceAsString(),
],
'Die Anfrage hat zu lange gedauert. Bitte versuche es erneut oder wende dich an den Kundenservice.',
$bookingCreateDto,
$form
);
} catch (\Exception $e) {
return $this->handleApiError(
$this->handleApiError(
'Booking inquiry exception',
[
'exception' => $e->getMessage(),
'trace' => $e->getTraceAsString(),
],
'Ein allgemeiner Fehler ist aufgetreten. Bitte wende dich an den Kundenservice.',
$bookingCreateDto,
$form
);
}
return $this->renderStepForm($bookingCreateDto, $form);
}
return $this->renderStepForm($bookingCreateDto, $form);