EP/myep
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: simplify trait to address incorrect arguments

Browse Source
This commit is contained in:
Björn Fromme
2026-03-28 10:18:34 +01:00
parent bca3610cff
commit fbfffbb31a
3 changed files with 23 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Controller/Booking/Create/Step4Controller.php
+8 -12
View File
@@ -92,13 +92,13 @@ class Step4Controller extends AbstractController
$bookingResponse = $this->apiClient->createBooking($bookingCreateDto);
if ($bookingResponse instanceof Notification) {
return $this->handleApiError(
$this->handleApiError(
'Booking creation failed - API notification',
['message' => $bookingResponse->message],
$bookingResponse->message ?? 'Ein Fehler ist aufgetreten. Bitte versuchen es erneut.',
$bookingCreateDto,
$form
);
return $this->renderStepForm($bookingCreateDto, $form, $newsletterOptInVisible, $newsletterTargetEmail);
}
if (false === $bookingResponse->isBookingSuccessful()) {
@@ -107,13 +107,13 @@ class Step4Controller extends AbstractController
$errorMessage .= ' '.$bookingResponse->message;
}
return $this->handleApiError(
$this->handleApiError(
'Booking creation unsuccessful',
['status' => $bookingResponse->status, 'message' => $bookingResponse->message],
$errorMessage,
$bookingCreateDto,
$form
);
return $this->renderStepForm($bookingCreateDto, $form, $newsletterOptInVisible, $newsletterTargetEmail);
}
$newsletterOptInSelected = $newsletterOptInVisible
@@ -147,26 +147,22 @@ class Step4Controller extends AbstractController
return $this->redirectToRoute('app_booking_create_success');
} catch (TimeoutException $e) {
return $this->handleApiError(
$this->handleApiError(
'Booking creation timeout',
[
'exception' => $e->getMessage(),
'trace' => $e->getTraceAsString(),
],
'Die Anfrage hat zu lange gedauert. Bitte versuche es erneut.',
$bookingCreateDto,
$form
);
} catch (\Exception $e) {
return $this->handleApiError(
$this->handleApiError(
'Booking creation exception',
[
'exception' => $e->getMessage(),
'trace' => $e->getTraceAsString(),
],
'Ein technischer Fehler ist aufgetreten.',
$bookingCreateDto,
$form
);
}
}