From fe2268c8971ac3015cd948755c779e224928afb4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= <fromme@dreipunktnull.com>
Date: Fri, 9 Jan 2026 10:05:21 +0100
Subject: [PATCH] feat: cleanup, log successful bookings

---
 src/Controller/Booking/Create/Step1Controller.php |  2 --
 src/Controller/Booking/Create/Step3Controller.php |  2 --
 src/Controller/Booking/Create/Step4Controller.php | 11 ++++++-----
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/Controller/Booking/Create/Step1Controller.php b/src/Controller/Booking/Create/Step1Controller.php
index 25a3402..6ef5670 100644
--- a/src/Controller/Booking/Create/Step1Controller.php
+++ b/src/Controller/Booking/Create/Step1Controller.php
@@ -110,8 +110,6 @@ class Step1Controller extends AbstractController
         ]);
         $form->handleRequest($request);
 
-        $this->bookingService->saveBookingDto($request, $bookingCreateDto, BookingDto::MODE_CREATE);
-
         // Get complete summary data (pricing, rooms, CMS data)
         $summaryData = $this->summaryDataService->getSummaryData($bookingCreateDto);
         $availableRooms = $bookingCreateDto->travel->getAvailableRooms();
diff --git a/src/Controller/Booking/Create/Step3Controller.php b/src/Controller/Booking/Create/Step3Controller.php
index 9deaaa7..c402adf 100644
--- a/src/Controller/Booking/Create/Step3Controller.php
+++ b/src/Controller/Booking/Create/Step3Controller.php
@@ -192,8 +192,6 @@ class Step3Controller extends AbstractController
         ]);
         $form->handleRequest($request);
 
-        $this->bookingService->saveBookingDto($request, $bookingCreateDto, BookingDto::MODE_CREATE);
-
         return $this->renderStepForm($bookingCreateDto, $form);
     }
 
diff --git a/src/Controller/Booking/Create/Step4Controller.php b/src/Controller/Booking/Create/Step4Controller.php
index a7da402..8bb2e1e 100644
--- a/src/Controller/Booking/Create/Step4Controller.php
+++ b/src/Controller/Booking/Create/Step4Controller.php
@@ -97,6 +97,12 @@ class Step4Controller extends AbstractController
                 $this->clearTravelDataCache($bookingCreateDto);
                 $this->bookingService->clearBookingDto($request, BookingDto::MODE_CREATE);
 
+                $this->logger->info('Booking successfully created.', [
+                    'date_id' => $bookingCreateDto->travel->id,
+                    'hotel_id' => $bookingCreateDto->hotelId,
+                    'booking_number' => $bookingResponse->transactionNumber,
+                ]);
+
                 return $this->redirectToRoute('app_booking_create_success');
             } catch (TimeoutException $e) {
                 return $this->handleApiError(
@@ -156,10 +162,5 @@ class Step4Controller extends AbstractController
         // Clear travel data cache (both local and remote variants)
         $this->cache->delete(sprintf('travel_unified_%d_%d_local', $dateId, $hotelId));
         $this->cache->delete(sprintf('travel_unified_%d_%d_remote', $dateId, $hotelId));
-
-        $this->logger->info('Cleared travel data cache after successful booking', [
-            'dateId' => $dateId,
-            'hotelId' => $hotelId,
-        ]);
     }
 }