From ff7ddf7a9ee175a29ce7a39ce02248022ea5a89c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= Date: Thu, 8 Oct 2026 11:44:37 +0200 Subject: [PATCH] feat: drop the TYPO3 api key query parameter --- config/services.yaml | 1 - src/Service/CmsDataProvider.php | 3 --- tests/Service/CmsDataProviderTest.php | 4 ++-- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/config/services.yaml b/config/services.yaml index 8d6c0982..65168946 100644 --- a/config/services.yaml +++ b/config/services.yaml @@ -336,7 +336,6 @@ services: App\Service\CmsDataProvider: arguments: $httpClient: '@typo3.client' - $apiKey: '%env(APP_CMS_API_KEY)%' App\Logger\RequestIdProcessor: tags: diff --git a/src/Service/CmsDataProvider.php b/src/Service/CmsDataProvider.php index ea322c11..c7e66845 100644 --- a/src/Service/CmsDataProvider.php +++ b/src/Service/CmsDataProvider.php @@ -14,7 +14,6 @@ class CmsDataProvider public function __construct( private readonly HttpClientInterface $httpClient, private readonly CacheInterface $cache, - private readonly string $apiKey, ) { } @@ -93,7 +92,6 @@ class CmsDataProvider $request = $this->httpClient->request('GET', 'api/hotel', [ 'query' => [ 'hotel' => $hotelCode, - 'key' => $this->apiKey, ], ]); } catch (ExceptionInterface $e) { @@ -184,7 +182,6 @@ class CmsDataProvider 'query' => [ 'product' => $productCode, 'hotel' => $hotelCode, - 'key' => $this->apiKey, ], ]); } catch (ExceptionInterface $e) { diff --git a/tests/Service/CmsDataProviderTest.php b/tests/Service/CmsDataProviderTest.php index 283421bd..aa7dc77d 100644 --- a/tests/Service/CmsDataProviderTest.php +++ b/tests/Service/CmsDataProviderTest.php @@ -45,7 +45,7 @@ class CmsDataProviderTest extends TestCase ], ], JSON_THROW_ON_ERROR))); - $provider = new CmsDataProvider($client, new ArrayAdapter(), 'test-key'); + $provider = new CmsDataProvider($client, new ArrayAdapter()); $data = $provider->getHotelDetails('HOTEL1'); @@ -75,7 +75,7 @@ class CmsDataProviderTest extends TestCase { $client = new MockHttpClient(fn () => new MockResponse('', ['http_code' => 500])); - $provider = new CmsDataProvider($client, new ArrayAdapter(), 'test-key'); + $provider = new CmsDataProvider($client, new ArrayAdapter()); self::assertNull($provider->getHotelDetails('UNKNOWN')); }