refactor: code quality via Rector, strict types where safe

rector.php gets the codeQuality set: declare(strict_types=1) in the 85
files where Rector finds no call relying on scalar type juggling (mostly
TCA and configuration, models, the content feed API and the import
command), "or die" as "|| die", instanceof instead of null checks for
object types, early returns and self:: in final classes.

Hotel::setRooms() goes instead of getting the property Rector wanted to
declare: nothing calls it, and there is no rooms column any more.

Checked locally: cache warmup, the ep:* commands load, frontend crawl
(~1,900 URLs) and the backchannel APIs render the same as before.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
frommeandClaude Opus 5.5 committed 2026-10-26 11:15:38 +01:00
1 parent f4556ee75c
commit 4fe06267c9
114 files changed
+278 -98

No files matched your search

@@ -22,7 +22,7 @@ class IconViewHelper extends AbstractTagBasedViewHelper
public function render(): string
{
$imageService = self::getImageService();
$imageService = $this->getImageService();
$sprite = $imageService->getImage('EXT:ep_theme/Resources/Public/images/icons_sprite.svg', null, false);
$imageUrl = $sprite->getPublicUrl();
@@ -33,7 +33,7 @@ class IconViewHelper extends AbstractTagBasedViewHelper
return $this->tag->render();
}
private static function getImageService()
private function getImageService()
{
return GeneralUtility::makeInstance(ImageService::class);
}