EP/typo3-13
4
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: code quality via Rector, strict types where safe

Browse Source 
rector.php gets the codeQuality set: declare(strict_types=1) in the 85
files where Rector finds no call relying on scalar type juggling (mostly
TCA and configuration, models, the content feed API and the import
command), "or die" as "|| die", instanceof instead of null checks for
object types, early returns and self:: in final classes.

Hotel::setRooms() goes instead of getting the property Rector wanted to
declare: nothing calls it, and there is no rooms column any more.

Checked locally: cache warmup, the ep:* commands load, frontend crawl
(~1,900 URLs) and the backchannel APIs render the same as before.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
frommeandClaude Opus 5.5 committed 2026-10-26 11:15:38 +01:00
1 parent f4556ee75c
commit 4fe06267c9
114 files changed
+278 -98
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

packages/ep_theme/Configuration/ContentSecurityPolicies.php
+2
View File
@@ -1,5 +1,7 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Security\ContentSecurityPolicy\Directive;
use TYPO3\CMS\Core\Security\ContentSecurityPolicy\Mutation;
use TYPO3\CMS\Core\Security\ContentSecurityPolicy\MutationCollection;
packages/ep_theme/Configuration/Icons.php
+2
View File
@@ -1,5 +1,7 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Imaging\IconProvider\BitmapIconProvider;
use TYPO3\CMS\Core\Imaging\IconProvider\SvgIconProvider;
packages/ep_theme/Configuration/RequestMiddlewares.php
+2
View File
@@ -1,5 +1,7 @@
<?php
declare(strict_types=1);
use EP\EpTheme\Middleware\CdnImageMiddleware;
use EP\EpTheme\Middleware\ReferrerMiddleware;
use EP\EpTheme\Middleware\HtmxRedirectMiddleware;
packages/ep_theme/Configuration/TCA/Overrides/pages.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function() {
packages/ep_theme/Configuration/TCA/Overrides/sys_template.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function () {
packages/ep_theme/Configuration/TCA/Overrides/tt_content.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function () {
packages/ep_theme/Configuration/TCA/Overrides/tt_content_element_button.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function() {
$frontendLanguageFilePrefix = 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:';
packages/ep_theme/Configuration/TCA/Overrides/tt_content_element_contact.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function() {
$frontendLanguageFilePrefix = 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:';
packages/ep_theme/Configuration/TCA/Overrides/tt_content_element_disrupter.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function() {
$frontendLanguageFilePrefix = 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:';
packages/ep_theme/Configuration/TCA/Overrides/tt_content_element_disturber.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function () {
$frontendLanguageFilePrefix = 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:';
packages/ep_theme/Configuration/TCA/Overrides/tt_content_element_faq_overview.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function() {
$frontendLanguageFilePrefix = 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:';
packages/ep_theme/Configuration/TCA/Overrides/tt_content_element_gmap.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function() {
$frontendLanguageFilePrefix = 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:';
packages/ep_theme/Configuration/TCA/Overrides/tt_content_element_lineup.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function() {
$frontendLanguageFilePrefix = 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:';
packages/ep_theme/Configuration/TCA/Overrides/tt_content_element_teaser.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function() {
$frontendLanguageFilePrefix = 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:';
packages/ep_theme/Configuration/TCA/Overrides/tt_content_element_ytvideo.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
defined('TYPO3') or die();
defined('TYPO3') || die();
call_user_func(function() {
$frontendLanguageFilePrefix = 'LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:';
packages/ep_theme/Configuration/TCA/Overrides/tt_content_preview.php
+3 -1
View File
@@ -1,8 +1,10 @@
<?php
declare(strict_types=1);
use EP\EpTheme\Preview\ContentPreviewRenderer;
defined('TYPO3') or die();
defined('TYPO3') || die();
// Page module previews (Templates/PreviewRenderer/<CType>.html); loads after tt_content_element_*.php
foreach (['teaser_country', 'teaser_region', 'teaser_city', 'teaser_hotel', 'teaser_concept', 'teaser_product',
packages/ep_theme/Configuration/TCA/Overrides/tx_eptheme_domain_model_badge.php
+2
View File
@@ -1,3 +1,5 @@
<?php
declare(strict_types=1);
$GLOBALS['TCA']['tx_eptheme_domain_model_badge']['ctrl']['security']['ignorePageTypeRestriction'] = true;
packages/ep_theme/Configuration/TCA/Overrides/tx_eptheme_domain_model_slide.php
+2
View File
@@ -1,3 +1,5 @@
<?php
declare(strict_types=1);
$GLOBALS['TCA']['tx_eptheme_domain_model_slide']['ctrl']['security']['ignorePageTypeRestriction'] = true;
packages/ep_theme/Configuration/TCA/tx_eptheme_domain_model_disrupter.php
+2
View File
@@ -1,5 +1,7 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Resource\FileType;
return [
packages/ep_theme/Configuration/TCA/tx_eptheme_domain_model_lineup.php
+2
View File
@@ -1,5 +1,7 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Resource\FileType;
return [
packages/ep_theme/Configuration/TCA/tx_eptheme_domain_model_slide.php
+2
View File
@@ -1,5 +1,7 @@
<?php
declare(strict_types=1);
use TYPO3\CMS\Core\Resource\FileType;
return [