From 3a357271be20ed22d0f554e4f82a0f8d86b23499 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bjo=CC=88rn=20Fromme?= Date: Tue, 3 Jul 2018 12:06:32 +0200 Subject: [PATCH] Fix incorrect typecasting of boolean value in filtersettings --- .../Classes/Traits/RequestArgumentTypeConversionTrait.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/web/typo3conf/ext/ep_products/Classes/Traits/RequestArgumentTypeConversionTrait.php b/web/typo3conf/ext/ep_products/Classes/Traits/RequestArgumentTypeConversionTrait.php index 5df48341..bb6138b4 100644 --- a/web/typo3conf/ext/ep_products/Classes/Traits/RequestArgumentTypeConversionTrait.php +++ b/web/typo3conf/ext/ep_products/Classes/Traits/RequestArgumentTypeConversionTrait.php @@ -82,7 +82,7 @@ trait RequestArgumentTypeConversionTrait $filterSettingsRaw = $this->request->getArgument('filterSettings'); if (is_array($filterSettingsRaw)) { - $filterSettings = (array) $filterSettingsRaw; + $filterSettings = $filterSettingsRaw; } elseif (is_string($filterSettingsRaw)) { $filterSettingsString = urldecode($filterSettingsRaw); $filterSettings = FilterSettingsEncoder::decode($filterSettingsString); @@ -94,8 +94,10 @@ trait RequestArgumentTypeConversionTrait $filterSettings['dateFrom'] = !empty($filterSettings['dateFrom']) ? new \DateTime($filterSettings['dateFrom']) : null; $filterSettings['dateTo'] = !empty($filterSettings['dateTo']) ? new \DateTime($filterSettings['dateTo']) : null; - if ($filterSettings['bus'] !== null) { - $filterSettings['bus'] = (bool) $filterSettings['bus']; + if (!empty($filterSettings['bus'])) { + $filterSettings['bus'] = $filterSettings['bus'] === 'true'; + } else { + $filterSettings['bus'] = null; } $filterSettingsObject = new FilterSettings();