From 5c857d3afc16bda11deaa752fd984643397c9b47 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= <fromme@dreipunktnull.com>
Date: Fri, 7 Jul 2023 09:42:36 +0200
Subject: [PATCH] Task: Simplify spam protection service

---
 .../Classes/Service/SpamProtectService.php    | 21 +++++++++----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/public/typo3conf/ext/ep_events/Classes/Service/SpamProtectService.php b/public/typo3conf/ext/ep_events/Classes/Service/SpamProtectService.php
index 2b7aa21a..720ab911 100644
--- a/public/typo3conf/ext/ep_events/Classes/Service/SpamProtectService.php
+++ b/public/typo3conf/ext/ep_events/Classes/Service/SpamProtectService.php
@@ -3,7 +3,6 @@
 namespace EP\EpEvents\Service;
 
 use Symfony\Component\HttpClient\HttpClient;
-use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface;
 use TYPO3\CMS\Core\SingletonInterface;
 
 class SpamProtectService implements SingletonInterface
@@ -13,23 +12,23 @@ class SpamProtectService implements SingletonInterface
         $client = HttpClient::create();
 
         try {
-            $response = $client->request('GET', 'https://api.stopforumspam.org/api', [
+            $response = $client->request('POST', 'https://api.stopforumspam.org/api', [
                 'query' => [
-                    'emailhash' => md5($email),
+                    'json' => true,
+                ],
+                'body' => [
+                    'email' => $email,
                 ]
             ]);
-            $result = simplexml_load_string($response->getContent());
-            $success = (bool)$result->attributes()['success'];
 
-            if (false === $success) {
+            $result = $response->toArray();
+
+            if (false === (bool) $result['success']) {
                 return false;
             }
 
-            $appears = (string)$result->appears === 'yes';
-            if (true === $appears) {
-                return true;
-            }
-        } catch (TransportExceptionInterface $e) {
+            return (bool) $result['appears'];
+        } catch (\Throwable $e) {
         }
 
         return false;