Apply best practice to form finisher registration

public/typo3conf/ext/ep_theme/Configuration/Forms/BaseSetup.yaml

@@ -0,0 +1,31 @@
+TYPO3:
+  CMS:
+    Form:
+      persistenceManager:
+        allowedExtensionPaths:
+          10: EXT:ep_theme/Resources/Private/Forms/
+
+      prototypes:
+        standard:
+
+          formElementsDefinition:
+            Form:
+              renderingOptions:
+                templateRootPaths:
+                  1505042810: 'EXT:ep_theme/Resources/Private/Templates/Form/'
+                partialRootPaths:
+                  1505042810: 'EXT:ep_theme/Resources/Private/Partials/Form/'
+                layoutRootPaths:
+                  1505042810: 'EXT:ep_theme/Resources/Private/Layouts/Form/'
+
+          finishersDefinition:
+            BpnApiFinisher:
+              implementationClassName: 'EP\EpTheme\Form\BpnApiFinisher'
+
+        contactform:
+          __inheritances:
+            10: 'TYPO3.CMS.Form.prototypes.standard'
+
+        applicationform:
+          __inheritances:
+            10: 'TYPO3.CMS.Form.prototypes.standard'

public/typo3conf/ext/ep_theme/Configuration/Forms/FormEditorSetup.yaml

@@ -1,35 +1,24 @@
 TYPO3:
   CMS:
     Form:
-      persistenceManager:
-        allowedExtensionPaths:
-          10: EXT:ep_theme/Resources/Private/Forms/
-
       prototypes:
         standard:
-          finishersDefinition:
-            BpnApiFinisher:
-              implementationClassName: 'EP\EpTheme\Form\BpnApiFinisher'
-              formEditor:
-                iconIdentifier: 'form-finisher'
-                label: 'BusPro Finisher'
-                predefinedDefaults:
-                  options:
-                    mapping: 'lastName:text-1,firstName:text-2,gender:singleselect-1,email:email-1,street:text-3,zipCode:text-4,city:text-5,phone:telephone-1'
           formElementsDefinition:
             Form:
               formEditor:
                 editors:
                   900:
                     selectOptions:
-                      1848:
+                      1000:
                         value: 'BpnApiFinisher'
                         label: 'BusPro Finisher'
                 propertyCollections:
                   finishers:
-                    1848:
+                    1000:
                       identifier: 'BpnApiFinisher'
                       editors:
+                        __inheritances:
+                          10: 'TYPO3.CMS.Form.mixins.formElementMixins.BaseCollectionEditorsMixin'
                         100:
                           label: 'BusPro Finisher'
                         110:
@@ -39,18 +28,11 @@ TYPO3:
                           propertyPath: 'options.mapping'
                           propertyValidators:
                             10: 'NotEmpty'
-              renderingOptions:
-                templateRootPaths:
-                  1505042810: 'EXT:ep_theme/Resources/Private/Templates/Form/'
-                partialRootPaths:
-                  1505042810: 'EXT:ep_theme/Resources/Private/Partials/Form/'
-                layoutRootPaths:
-                  1505042810: 'EXT:ep_theme/Resources/Private/Layouts/Form/'
 
-        contactform:
+          finishersDefinition:
-          __inheritances:
+            BpnApiFinisher:
-            10: 'TYPO3.CMS.Form.prototypes.standard'
+              formEditor:
-
+                iconIdentifier: 'form-finisher'
-        applicationform:
+                predefinedDefaults:
-          __inheritances:
+                  options:
-            10: 'TYPO3.CMS.Form.prototypes.standard'
+                    mapping: 'lastName:text-1,firstName:text-2,gender:singleselect-1,email:email-1,street:text-3,zipCode:text-4,city:text-5,phone:telephone-1'

public/typo3conf/ext/ep_theme/Configuration/Forms/FormEngineSetup.yaml

@@ -0,0 +1,9 @@
+TYPO3:
+  CMS:
+    Form:
+      prototypes:
+        standard:
+          finishersDefinition:
+            BpnApiFinisher:
+              FormEngine:
+                label: 'BusPro Finisher'

public/typo3conf/ext/ep_theme/Configuration/TypoScript/Extensions/Form.typoscript

@@ -6,9 +6,12 @@ plugin.tx_form.view {
 }
 
 plugin.tx_form.settings.yamlConfigurations {
-    100 = EXT:ep_theme/Configuration/Forms/FormSetup.yaml
+    1630994710 = EXT:ep_theme/Configuration/Forms/BaseSetup.yaml
+    1630994711 = EXT:ep_theme/Configuration/Forms/FormEngineSetup.yaml
 }
 
 module.tx_form.settings.yamlConfigurations {
-    100 = EXT:ep_theme/Configuration/Forms/FormSetup.yaml
+    1630994710 = EXT:ep_theme/Configuration/Forms/BaseSetup.yaml
+    1630994711 = EXT:ep_theme/Configuration/Forms/FormEditorSetup.yaml
+    1630994712 = EXT:ep_theme/Configuration/Forms/FormEngineSetup.yaml
 }