From c31ef96b3c743af7ff5b7dc095f88ae4cde34155 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bjo=CC=88rn=20Fromme?= Date: Sun, 2 Dec 2018 13:56:26 +0100 Subject: [PATCH] Simplify code --- .../Classes/Service/ContingentImportService.php | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/web/typo3conf/ext/ep_products/Classes/Service/ContingentImportService.php b/web/typo3conf/ext/ep_products/Classes/Service/ContingentImportService.php index 356a43d8..db97c38b 100644 --- a/web/typo3conf/ext/ep_products/Classes/Service/ContingentImportService.php +++ b/web/typo3conf/ext/ep_products/Classes/Service/ContingentImportService.php @@ -224,8 +224,6 @@ class ContingentImportService implements SingletonInterface { $date = \DateTime::createFromFormat('d.m.Y', (string) $xmlDate['termin']); $status = Contingent::STATUS_OK; - $statusBlocked = false; - $statusOnRequest = false; foreach ($xmlDate->zimmerliste->children() as $xmlRoom) { $roomTypeBusProId = (string) $xmlRoom['idbuspro']; @@ -237,10 +235,10 @@ class ContingentImportService implements SingletonInterface $availablePax = 0; if ($roomType['ctrl'] === true) { if ((string) $xmlRoom['status'] === 'A') { - $statusOnRequest = true; + $status = Contingent::STATUS_ONREQUEST; } if ((string) $xmlRoom['status'] === 'S') { - $statusBlocked = true; + $status = Contingent::STATUS_BLOCKED; } } else { $pax = $roomType['pax'] * (int) $xmlRoom['kontingent']; @@ -250,11 +248,6 @@ class ContingentImportService implements SingletonInterface if ($availablePax === 0) { continue; } - if ($statusBlocked) { - $status = Contingent::STATUS_BLOCKED; - } elseif ($statusOnRequest) { - $status = Contingent::STATUS_ONREQUEST; - } $minPrice = (int) $xmlRoom['abpreis']; $minNights = (int) $xmlRoom['abpreis_naechte']; $additionalNightMinPrice = (int) $xmlRoom['abpreis_verlaengerung'];