From d06f1814e66cf279ee7469b1787941e89c464919 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Fromme?= Date: Tue, 26 Nov 2024 15:11:11 +0100 Subject: [PATCH] fix: return 404 page for invalid travelinfo urls --- .../Classes/Controller/TravelinfoController.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/public/typo3conf/ext/ep_products/Classes/Controller/TravelinfoController.php b/public/typo3conf/ext/ep_products/Classes/Controller/TravelinfoController.php index 4defbe08..8f03cdf6 100644 --- a/public/typo3conf/ext/ep_products/Classes/Controller/TravelinfoController.php +++ b/public/typo3conf/ext/ep_products/Classes/Controller/TravelinfoController.php @@ -33,6 +33,7 @@ class TravelinfoController extends ActionController { /** @var Date $date */ $date = $this->dateRepository->findOneByBusProId($busProId); + $travelinfo = $this->travelInfoRepository->findOneByProduct($date->getProduct()); if (null === $travelinfo) { @@ -60,6 +61,15 @@ class TravelinfoController extends ActionController /** @var Date $date */ $date = $this->dateRepository->findForProductAndDate($product, $travelDate)->getFirst(); + + if (null === $date) { + $response = GeneralUtility::makeInstance(ErrorController::class)->pageNotFoundAction( + $GLOBALS['TYPO3_REQUEST'], + 'Reiseinformationen nicht gefunden' + ); + throw new ImmediateResponseException($response, 1731071856); + } + $hasCourses = 0 < count($date->getServicesGeneral('KUR')); $this->view->assign('travelinfo', $travelinfo);