Task: Simplify code

This commit is contained in:
Björn Fromme
2023-08-03 11:35:46 +02:00
parent 137ece5f78
commit e0e42172c9
@@ -162,7 +162,7 @@ class GroupsSwissService implements SingletonInterface, LoggerAwareInterface
return Contingent::STATUS_BLOCKED; return Contingent::STATUS_BLOCKED;
} }
if ($percentageAvailable > 20 && $percentageAvailable <= 80) { if ($percentageAvailable <= 80) {
return $contingent::STATUS_ONREQUEST; return $contingent::STATUS_ONREQUEST;
} }
@@ -177,25 +177,31 @@ class GroupsSwissService implements SingletonInterface, LoggerAwareInterface
*/ */
protected function addItem(array $item, $status, $apiKey, $houseNumber): void protected function addItem(array $item, $status, $apiKey, $houseNumber): void
{ {
$from = $item['from']->format('Y-m-d');
$to = $item['to']->format('Y-m-d');
$this->logger->info(sprintf( $this->logger->info(sprintf(
'Adding status %d in %s-%s for %s', 'Adding status %d in %s-%s for %s',
$status, $status,
$item['from']->format('Y-m-d'), $from,
$item['to']->format('Y-m-d'), $to,
$houseNumber $houseNumber
)); ));
$url = sprintf(
'https://www.groups.swiss/api/1.0/json.php?apiKey=%s&method=setAvailabilityChart&house=%d&from=%s&till=%s&state=%d',
$apiKey,
$houseNumber,
$item['from']->format('Y-m-d'),
$item['to']->format('Y-m-d'),
$status
);
try { try {
$response = $this->httpClient->request('GET', $url); $response = $this
->httpClient
->request('GET', 'https://www.groups.swiss/api/1.0/json.php', [
'query' => [
'apiKey' => $apiKey,
'method' => 'setAvailabilityChart',
'house' => $houseNumber,
'from' => $from,
'till' => $to,
'state' => $status,
],
])
;
$this->logger->info($response->getContent()); $this->logger->info($response->getContent());
} catch (TransportExceptionInterface $e) { } catch (TransportExceptionInterface $e) {
$this->logger->error(sprintf('A problem occured: %s', $e->getMessage())); $this->logger->error(sprintf('A problem occured: %s', $e->getMessage()));