EP/myep-team
4
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: drop status breakdown from applications-by-destination stats

Browse Source
This commit is contained in:
fromme committed 2026-09-01 09:46:01 +02:00
1 parent f6667dcfc7
commit 0d06bc4271
3 files changed
+13 -36
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/Repository/ApplicationRepositoryTest.php
+6 -4
View File
@@ -86,13 +86,15 @@ class ApplicationRepositoryTest extends KernelTestCase
$this->assertStringContainsString('INNER JOIN assignment.destination destination', $dql);
}
public function testApplicationsByDestinationBindsTheStatusBuckets(): void
public function testApplicationsByDestinationCountsEveryApplicationRegardlessOfStatus(): void
{
$query = $this->createApplicationsByDestinationQuery();
$dql = $query->getDQL();
$this->assertSame(Application::STATUS_NEW, $query->getParameter('statusNew')->getValue());
$this->assertSame(Application::STATUS_PENDING, $query->getParameter('statusPending')->getValue());
$this->assertSame(Application::STATUS_REJECTED, $query->getParameter('statusRejected')->getValue());
// status moves over an application's lifetime, so it is not broken out - a plain count
$this->assertStringContainsString('COUNT(application.id)', $dql);
$this->assertStringNotContainsStringIgnoringCase('application.status', $dql);
$this->assertNull($query->getParameter('statusNew'));
}
public function testApplicationsByDestinationAppliesTheSeasonBoundsOnlyWhenGiven(): void