Fix incorrect typecasting of boolean value in filtersettings

This commit is contained in:
Björn Fromme
2018-07-03 12:06:32 +02:00
parent 4b73b37f4a
commit 3a357271be
@@ -82,7 +82,7 @@ trait RequestArgumentTypeConversionTrait
$filterSettingsRaw = $this->request->getArgument('filterSettings');
if (is_array($filterSettingsRaw)) {
$filterSettings = (array) $filterSettingsRaw;
$filterSettings = $filterSettingsRaw;
} elseif (is_string($filterSettingsRaw)) {
$filterSettingsString = urldecode($filterSettingsRaw);
$filterSettings = FilterSettingsEncoder::decode($filterSettingsString);
@@ -94,8 +94,10 @@ trait RequestArgumentTypeConversionTrait
$filterSettings['dateFrom'] = !empty($filterSettings['dateFrom']) ? new \DateTime($filterSettings['dateFrom']) : null;
$filterSettings['dateTo'] = !empty($filterSettings['dateTo']) ? new \DateTime($filterSettings['dateTo']) : null;
if ($filterSettings['bus'] !== null) {
$filterSettings['bus'] = (bool) $filterSettings['bus'];
if (!empty($filterSettings['bus'])) {
$filterSettings['bus'] = $filterSettings['bus'] === 'true';
} else {
$filterSettings['bus'] = null;
}
$filterSettingsObject = new FilterSettings();